Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions runs tests twice #864

Open
clone1018 opened this issue Sep 12, 2022 · 1 comment
Open

GitHub Actions runs tests twice #864

clone1018 opened this issue Sep 12, 2022 · 1 comment
Labels
dev-x Improves the developer experience good first issue Good for newcomers

Comments

@clone1018
Copy link
Member

Since we have both a mix test and mix coveralls our tests end up running twice, we could save half the time by figuring out how to consolidate it.

@clone1018 clone1018 added good first issue Good for newcomers dev-x Improves the developer experience labels Sep 12, 2022
@dmarcoux
Copy link

dmarcoux commented Jan 30, 2023

Dropping mix test should be enough, no?

I see from the GitHub workflow configure that it apparently fails with a 500 error from time to time. This could be addressed by splitting the generation of the code coverage data and the upload of that data. The first step would be to run mix coveralls.json, then the Coveralls GitHub action would upload the data generated by that mix task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-x Improves the developer experience good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants