Homepage showing more than 6 streams

[clone1018]

Shouldn't technically be possible, but it looks like we have a misconfigured query somewhere...

Database State:

id	channel_id	slot_started_at	slot_ended_at
1902	10552	2021-04-23 13:53:54	2021-04-23 14:53:54
1901	5600	2021-04-23 13:53:54	2021-04-23 14:53:54
1900	7538	2021-04-23 13:53:54	2021-04-23 14:53:54
1899	12937	2021-04-23 13:53:54	2021-04-23 14:53:54
1898	13204	2021-04-23 13:53:54	2021-04-23 14:53:54
1897	503	2021-04-23 13:53:54	2021-04-23 14:53:54
1896	7538	2021-04-23 13:53:54	2021-04-23 14:53:54
1895	13204	2021-04-23 13:53:54	2021-04-23 14:53:54
1894	503	2021-04-23 13:53:54	2021-04-23 14:53:54
1893	5600	2021-04-23 13:53:54	2021-04-23 14:53:54
1892	10552	2021-04-23 13:53:54	2021-04-23 14:53:54
1891	14586	2021-04-23 13:53:54	2021-04-23 14:53:54

[clone1018]

Oops, I think there should be a group_by here:

glimesh.tv/lib/glimesh/homepage.ex

Lines 84 to 100 in 1f6d25a

	Repo.all(
	from c in Channel,
	as: :channel,
	join: s in assoc(c, :streams),
	on: c.stream_id == s.id,
	join: u in assoc(c, :user),
	on: c.user_id == u.id,
	where:
	c.status == "live" and
	c.show_on_homepage and
	s.started_at <= ^fifteen_minutes_ago and
	is_nil(s.ended_at) and
	c.id in subquery(ten_hour_query),
	limit: 6,
	order_by: fragment("RANDOM()")
	)
	end

[clone1018]

Looking into this more, it's not reproducible in development. It's likely the homepage generator script is either being run by two nodes, or the same node is running it twice!

[Eein]

worst case you can cap limit 6 after the query to chop off the end :) that would be the easiest fix as long as there isn't a major performance cost to doing a Repo.all