Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error raising consistent for iterative affine co-registration in case of divergence #653

Open
rhugonnet opened this issue Nov 15, 2024 · 0 comments
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request test-suite Issue related to testing

Comments

@rhugonnet
Copy link
Contributor

For most AffineCoreg classes, sampled valid values change at each iteration (NaNs propagate depending on iterative shift/rotation).
Currently, only NuthKaab has an error raised in that case:

raise ValueError(

We should make this sampling error due to divergence consistent across all these functions (ICP, DhMinimize, etc), maybe as a common error class DivergenceError. Error catching will be different for methods who are iterative within their minimizer (like DhMinimize) and not within xDEM, there we'll need to catch an exception.

And we should also add tests for this: Not easy to reproduce, as the methods can find local minima without always completely diverging to the point of having no more samples...

@rhugonnet rhugonnet added enhancement Feature improvement or request test-suite Issue related to testing architecture Need to re-organize or re-structure something labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request test-suite Issue related to testing
Projects
None yet
Development

No branches or pull requests

1 participant