Make error raising consistent for iterative affine co-registration in case of divergence #653
Labels
architecture
Need to re-organize or re-structure something
enhancement
Feature improvement or request
test-suite
Issue related to testing
For most
AffineCoreg
classes, sampled valid values change at each iteration (NaNs propagate depending on iterative shift/rotation).Currently, only
NuthKaab
has an error raised in that case:xdem/xdem/coreg/affine.py
Line 464 in 22dbe7c
We should make this sampling error due to divergence consistent across all these functions (
ICP
,DhMinimize
, etc), maybe as a common error classDivergenceError
. Error catching will be different for methods who are iterative within their minimizer (likeDhMinimize
) and not within xDEM, there we'll need to catch an exception.And we should also add tests for this: Not easy to reproduce, as the methods can find local minima without always completely diverging to the point of having no more samples...
The text was updated successfully, but these errors were encountered: