Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a problem in switch network when my network is set on solana #4768

Open
maryjaf opened this issue Sep 24, 2024 · 4 comments
Open

There is a problem in switch network when my network is set on solana #4768

maryjaf opened this issue Sep 24, 2024 · 4 comments
Assignees

Comments

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 24, 2024

          There is a problem in switch network but I think it isn't exactly related to this issue and changes, please take a look on below screen records 
  • when my network is set on op , I change the network to solana, and then change it to gnosis , in this case my network is set on op as one step before solana
Screen.Recording.2024-09-24.at.10.06.02.AM.mov
  • when my network is set on op , I change the network to solana, and then change it to OP again , in this case that the network before and after solana are same, there is no problem in switch network
Screen.Recording.2024-09-24.at.10.06.28.AM.mov

@MoeNick @RamRamez
cc: @divine-comedian I think it's related to the change had been made by Mateo before

Originally posted by @maryjaf in #4731 (comment)

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Sep 24, 2024
@maryjaf maryjaf changed the title There is a problem in switch network but I think it isn't exactly related to this issue and changes, please take a look on below screen records There is a problem in switch network when my network is set on solana Sep 24, 2024
@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 24, 2024

production :

Screen.Recording.2024-09-24.at.10.55.49.AM.mov

@mateodaza @divine-comedian

@divine-comedian
Copy link
Contributor

Looks like when you are switching from solana to a new EVM network (not the one you were previously connected to) MM is handling only the website connection and not following up with a switch network request.

@divine-comedian divine-comedian moved this from New Issues to Dev Research in All-Devs Sep 24, 2024
@mateodaza
Copy link
Member

mateodaza commented Sep 24, 2024

Been pretty hard to solve this using @web3modal/wagmi/react directly so built a workaround

leaving a PR here

cc: @divine-comedian @maryjaf @MohammadPCh @RamRamez

@maryjaf
Copy link
Collaborator Author

maryjaf commented Sep 25, 2024

Thanks @mateodaza please let me know when it is ready for testing on stg

@divine-comedian divine-comedian moved this from Dev Research to Code Review/PR in All-Devs Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Code Review/PR
Development

No branches or pull requests

3 participants