Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continua Ci - uses registry - needs fix #1278

Closed
dazinator opened this issue Aug 16, 2017 · 1 comment
Closed

Continua Ci - uses registry - needs fix #1278

dazinator opened this issue Aug 16, 2017 · 1 comment

Comments

@dazinator
Copy link
Member

dazinator commented Aug 16, 2017 •
edited
Loading

Originated from #1269:

I had to remove ContinuaCI support from NETStandard build - as lack of registry API's.

Why does it need access to the registry? It should just check if environment variables are registered, same as on Cake:

https://github.com/cake-build/cake/blob/08907d1a5d97b66f58c01ae82506280882dcfacc/src/Cake.Common/Build/ContinuaCI/ContinuaCIProvider.cs#L62
@dazinator dazinator mentioned this issue Aug 16, 2017
Merged
@dazinator dazinator changed the title Continua Ci - needs fix Continua Ci - uses registry - needs fix Aug 16, 2017
dazinator added a commit to dazinator/GitVersion that referenced this issue Aug 16, 2017
@dazinator
Fixes GitTools#1278 - ContinuaCI use environment variable not registry.
21cb7f0
@dazinator dazinator mentioned this issue Aug 16, 2017
Merged
@dazinator
Copy link
Member Author

PR submitted.

dazinator added a commit that referenced this issue Aug 16, 2017
@dazinator
Merge pull request #1279 from dazinator/issue-1278
443c994 
Fixes #1278 - ContinuaCI use environment variable not registry.
dazinator added a commit to dazinator/GitVersion that referenced this issue Aug 16, 2017
@dazinator
Fixes GitTools#1278 - ContinuaCI use environment variable not registry.
75b4e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dazinator