Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Make it possible to change the crafting recipes of some items with Datapacks #83

Open
Yoni664 opened this issue Jun 18, 2024 · 2 comments

Comments

@Yoni664
Copy link

Yoni664 commented Jun 18, 2024

Make it possible to change the manufacturing recipes for the dragon horse armor, winged dragon scale armor, dragon bow, dragon crossbow and dragon trident with datapacks.

I am modifying these crafting recipes for my personal use as I find myself also using the Deeper and Darker, Better End and LieOnLions Enderite mods. I prefer to use items that add these mods for dragon armor crafting rather than simply using netherite items and the netherite smithing template.

Actually I was already able to modify the ones in the following address: "data/dragonloot/recipes" but I can't change the ones for the other items, I tried to simply create a file for each item I mentioned above but it didn't work.

Im leaving the next images just for references:

In this image u can see that I already change the crafting recipe for the sword:
sworddragonproof

In this image u can see that verything is working:
Minecraft Screenshot 2024 06 17 - 20 20 42 18

The recipes folder doesn´t provide a file to modify the horse armor with a JSON file, so I decided to create one thinking that it was goin to work:
horsearmorproof
horsearmorproof2

And sadly it didn't work :(
Minecraft Screenshot 2024 06 17 - 20 23 20 74

@Yoni664
Copy link
Author

Yoni664 commented Jun 18, 2024

I also posted this in Discord.

@spanditime
Copy link

spanditime commented Oct 10, 2024

@Yoni664 - any movement? Was trying to come up with a modpack. Decided to balance things up as i use advancednetherite mod, and write a simple datapack - that blocks the recipes and replaces them with new ones.

{
  "pack":{ 
    "pack_format":48,
    "description":"...."
  },
  "filter":{
    "block": [
.....
      {
        "namespace":"dragonloot",
        "path":"recipe/dragon_bow.json"
      },
      {
        "namespace":"dragonloot",
        "path":"recipe/dragon_crossbow.json"
      },
      {
        "namespace":"dragonloot",
        "path":"recipe/dragon_trident.json"
      },
      {
        "namespace":"dragonloot",
        "path":"recipe/dragon_horse_armor.json"
      },
.....
    ]
  }
}

those are the recipes that are not removable - i think because of the compat/recipes
Wouldn't it be better to provide separate datapacks for compat recipes? Or fix the fact that the recipes are loaded after the datapacks so that users can alter them in any way they want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants