Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for header and footer component, dragging style, disable certain items... #12

Open
haveneersrobin opened this issue Aug 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@haveneersrobin
Copy link

haveneersrobin commented Aug 18, 2021

New feature motivation

This library seems to be being maintained, compared to other draggable list libraries and it seems to work well. Nonetheless, it is missing some features to be completely useful.

New feature description

  • Support for footer and header component: pass (non draggable) footer and header components to display on top or below list
  • Pass custom style when dragging an item (this is probably only useful is custom heights are also supported)
  • On a per-item level: prevent items from being dragged
  • Passing id to custom components give typescript errors, even though it is needed for the DraggableList to work. Perhaps a 'idExtractor' method (or something similar) can be passed via a prop to the DraggableList instead.
  • Add onDragBegin for example to give haptic feedback

I can try some of these in the coming days/weeks and create pull requests if that is something you are open to?

@GiridharKarnik
Copy link
Owner

Hi @haveneersrobin, thanks for raising this feature request. I am working on a bunch of features too and I can definitely look into some of the things you have listed.

@GiridharKarnik GiridharKarnik added the enhancement New feature or request label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants