Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getmac fails finding Android 12 MAC #95

Open
emadmahdi opened this issue Dec 7, 2023 · 1 comment
Open

getmac fails finding Android 12 MAC #95

emadmahdi opened this issue Dec 7, 2023 · 1 comment

Comments

@emadmahdi
Copy link
Contributor

emadmahdi commented Dec 7, 2023

Hi,
I created a test script to find out why your getmac package cannot find the MAC of an Android 12 device (Amazon Fire Stick Gen 2) .. location of my script:

script: . . . https://muslimruler.netlify.app/public/macproblem
output sample: . . . https://nopaste.net/output_sample.txt

From my script results .. I knew the problem was that .. most network commands does not exist on that Android 12 device .. The solution was very simple .. Just install busybox binary file and that will allow your getmac package to have a full access to all missing network commands.

So I suggest you add busybox binary file to your python package .. it is around 1.5MB file size .. You can add it to your list of methods as method number "28".

I also suggest that you add something in your getmac package that will inform users that .. required network commands are missing from the device.

Or you can add busybox as an optional downloadable file.

Thank you,
Emad

@GhostofGoes
Copy link
Owner

Hey @emadmahdi , sorry I never replied to your issue. I'm against adding any binary to the distribution, let alone one that only benefits a specific platform. That being said, documenting the limitation is something that should absolutely be done. Additionally, to alleviate the issue of the binary being missing, perhaps adding documentation on how to create a custom distribution with the binary, or otherwise inject the binary into a place it can be used.

Could you please elaborate on what changes exactly are needed to make it work? The links you posted were not informative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants