Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Structures to publish in APIv2 #4436

Open
Chatewgne opened this issue Dec 31, 2024 · 1 comment
Open

Missing Structures to publish in APIv2 #4436

Chatewgne opened this issue Dec 31, 2024 · 1 comment
Labels

Comments

@Chatewgne
Copy link
Contributor

Chatewgne commented Dec 31, 2024

Describe the bug

Structures appear in APIv2 if they are related to a published Trek or a published Touristic Content. This is not exhaustive, we should also check for 7 other models that are related to Structure : Infrastructure, Signage, POI, Service, Touristic Event, Site, Course.

(As a result, some objects might not appear in GeotrekAggregator because their mandatory structure wasn't found and they aren't downloaded - we have to bypass this by not aggregating the Structure)

Here is the draft for a fix : #4435 but this isn't viable because the request is way too slow.

We need to find a more efficient way to filter for published related objects in APIv2, especially if we have so many different models to check for.

@camillemonchicourt
Copy link
Member

This is for /structure/ route ?
Maybe this route could just return all structures in Geotrek-admin instance ?
Or we could add a "published" field on this table ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants