Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define normalized response structure #35

Open
danibishop opened this issue Jan 29, 2019 · 2 comments
Open

Define normalized response structure #35

danibishop opened this issue Jan 29, 2019 · 2 comments

Comments

@danibishop
Copy link

We need a common structure for query responses regardless of what datasource is being used.

@josemazo
Copy link
Contributor

The one you proposed looks nice to me, but the rows, the need to be key-value pairs. It would be awesome if we can also obtain the fields and the response_time in the same query with PG. And the cache field is what excites me the most.

@danibishop
Copy link
Author

I implemented the CARTO row style (including field name) for the default response. I added some profiling values that should be revised/rethinked. For now, some elapsed times, which are specific for each data source.

danibishop pushed a commit that referenced this issue Jan 30, 2019
…tored including field name, following the CARTO style. Closes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants