Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to show clipboard updates in verbose mode #3914

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ssailly
Copy link

@ssailly ssailly commented Apr 13, 2023

This implements the feature suggested by #3475.

When copying from the device, then copy-pasting from the computer to the device using Ctrl+V, and running with -Vdebug --show-clipboard :

  • Before:
INFO: Device clipboard copied
DEBUG: Computer clipboard set

[server] INFO: Device clipboard set
DEBUG: Computer clipboard unchanged
  • After:
INFO: Device clipboard copied: This application mirrors Android devices
DEBUG: Computer clipboard set: This application mirrors Android devices

[server] INFO: Device clipboard set: It works on Linux
DEBUG: Computer clipboard unchanged

Running without --show-clipboard has the same behavior as "Before".

Add an option to show the content of clipboards when they are updated
@rom1v
Copy link
Collaborator

rom1v commented Apr 14, 2023

Thank you for your contribution.

Small remarks inline after a quick review.

@rom1v
Copy link
Collaborator

rom1v commented Apr 14, 2023

By default, the clipboard content must not be printed (it may contain sensitive information).

However, I'm wondering if we could just log it in verbose mode (without adding yet another very-specific niche option). (not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants