Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAYER-30] remplace the key 'keys' to 'key' for keympapping tap et swipe #94

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Aug 7, 2024

Description

replace the key named keys to 'key' for tap and swipe in the json config

update json keymapping config.

TYPE:[{
        keys: {
            p: {
                initialX: 50,
                initialY: 50,
            },
        }
        name:'Fire'
    }],

to

dPad:[{
        keys: {
            key: 'p',
            effect: {
                initialX: 50,
                initialY: 50,
            },
        }
        name:'Fire'
    }],
tap:[{
         key: 'p',
         effect: {
             initialX: 50,
             initialY: 50,
         },
         name:'Fire'
    }],

@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch from 5835308 to fa98dd3 Compare August 7, 2024 13:06
@jparez jparez requested review from pgivel and OoDeLally August 7, 2024 13:08
@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch from fa98dd3 to c6dd848 Compare August 7, 2024 15:07
@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch from c6dd848 to 274a503 Compare August 7, 2024 15:23
@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch 2 times, most recently from 7d83f25 to f00b6fc Compare August 9, 2024 11:01
dpad?: KeyMap<KeyEffect & KeyEffectDistance>[];
tap?: KeyMap<KeyEffect>[];
swipe?: KeyMap<KeyEffect & KeyEffectDistance>[];
dpad?: KeyList<KeyEffect & KeyEffectDistance>[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this stay a KeyList with the latest rework ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the D-pad can handle multiple keys as a single input, while tap and swipe can each only be a single key.

@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch from f00b6fc to 277926d Compare September 2, 2024 09:06
@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch from 277926d to a6f743a Compare September 2, 2024 09:18
@jparez jparez force-pushed the dev/PLAYER-30-change-keymapping-config-json branch from a6f743a to c23c0d4 Compare September 3, 2024 07:32
@jparez jparez merged commit 9376b49 into main Sep 3, 2024
1 check passed
@jparez jparez deleted the dev/PLAYER-30-change-keymapping-config-json branch September 3, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants