[PLAYER-31] fix wrong calculation border with css scale rule #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparez
force-pushed
the
dev/PLAYER-31-fix-wrong-calculation-border-with-css-scale-rule
branch
from
226ded4
to
a293e23
Compare
jparez
force-pushed
the
dev/PLAYER-31-fix-wrong-calculation-border-with-css-scale-rule
branch
from
a293e23
to
9ea4dc6
Compare
pgivel
approved these changes
Aug 7, 2024
jparez
deleted the
dev/PLAYER-31-fix-wrong-calculation-border-with-css-scale-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a css rules (i.e. scale) is set on the player's HTML element the calculation of borders is wrong. This is caused by the offset's browser api which doesn't take css rules in this calculation