Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAYER-39] adding player version to js and css minified files #104

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[PLAYER-39] adding player version to js and css minified files #104

merged 1 commit into from
Sep 20, 2024

Conversation

jparez
Copy link
Contributor

@jparez jparez commented Sep 19, 2024

Description

Adding version to minified files

Type of change

  • New feature (non-breaking change which adds functionality)

@jparez jparez changed the title adding player version to js and css minified files [PLAYER-39] adding player version to js and css minified files Sep 19, 2024
@jparez jparez force-pushed the dev/PLAYER-39-adding-version-to-minified-js-and-css branch from b8c0431 to f2594ec Compare September 19, 2024 14:01
pgivel
pgivel reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@pgivel pgivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one change I don't understand, LGTM otherwise

gulpfile.js Show resolved Hide resolved
@jparez jparez merged commit f76e163 into main Sep 20, 2024
1 check passed
@jparez jparez deleted the dev/PLAYER-39-adding-version-to-minified-js-and-css branch September 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgivel pgivel pgivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparez @pgivel