Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

784 bug capres flag for transmission lines does not appear to do anything #797

Conversation

lbonaldo
Copy link
Collaborator

@lbonaldo lbonaldo commented Nov 25, 2024

Description

Addresses #784 by updating the documentation for the Network.csv file and removing the CapRes_* column from examples and tests. It should now be clearer that users should use the following:

  • CapResExcl_* != 0: enables the contribution of the transmission line to the Capacity Reserve Margin (CRM).
  • CapResExcl_* == -1: indicates that the designated direction of the transmission line is inbound to the LDA.
  • CapResExcl_* == 1: direction of the transmission line is outbound from the LDA.

What type of PR is this? (check all applicable)

  • Documentation Update

Related Tickets & Documents

Addresses #784.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Example case 7_three_zones_w_colocated_VRE_storage.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from gmantegna November 25, 2024 15:15
@lbonaldo
Copy link
Collaborator Author

@gschivley

@lbonaldo lbonaldo added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Nov 25, 2024
Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lbonaldo lbonaldo force-pushed the 784-bug-capres-flag-for-transmission-lines-does-not-appear-to-do-anything branch from 291703c to 652c611 Compare November 26, 2024 22:18
@lbonaldo lbonaldo force-pushed the 784-bug-capres-flag-for-transmission-lines-does-not-appear-to-do-anything branch from 652c611 to 0089f1e Compare November 26, 2024 22:18
@lbonaldo lbonaldo merged commit 5b0c5ff into develop Nov 26, 2024
9 checks passed
@lbonaldo lbonaldo deleted the 784-bug-capres-flag-for-transmission-lines-does-not-appear-to-do-anything branch November 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants