Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor write_capacityfactor.jl #757

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

cfe316
Copy link
Collaborator

@cfe316 cfe316 commented Aug 21, 2024

Description

Refactor write_capacityfactor. (This was mostly done while investigating how the function works, in order to make a modification for fusion.)
This hopefully clarifies the computations that the function does.

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Code Refactor
  • Performance Improvements

Related Tickets & Documents

n/a

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Test examples 7 and 8; see that capacityfactor.csv is unchanged.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It just needs to be rebased with the current develop, and then it will be ready to be merged. Thanks @cfe316!

Abstract some of the extraction of values from the model to improve
readability.
@cfe316 cfe316 force-pushed the refactor_write_capacityfactor branch from 5003a99 to d70e031 Compare August 22, 2024 13:45
@cfe316
Copy link
Collaborator Author

cfe316 commented Aug 22, 2024

I've now rebased it ✅ . Ready to go.

@lbonaldo lbonaldo merged commit 1c7adb7 into develop Aug 22, 2024
9 checks passed
@lbonaldo lbonaldo deleted the refactor_write_capacityfactor branch August 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants