Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial fixes #698

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Tutorial fixes #698

merged 4 commits into from
Jun 17, 2024

Conversation

mmutic
Copy link
Collaborator

@mmutic mmutic commented May 16, 2024

Description

What type of PR is this?

  • Documentation Update

Related Tickets & Documents

Issue #697

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

sambuddhac and others added 2 commits May 5, 2024 20:40
@mmutic mmutic linked an issue May 24, 2024 that may be closed by this pull request
@lbonaldo lbonaldo self-requested a review June 17, 2024 15:14
Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks ready to me. Thank you @mmutic!

@lbonaldo lbonaldo merged commit 7847a5a into develop Jun 17, 2024
7 checks passed
@lbonaldo lbonaldo deleted the tutorial_fixes branch June 17, 2024 15:33
@M0-Adnan
Copy link

Hi,

I can see that merge pull request is verified but still on GenX page, documentation error is same as it was before.
image

@lbonaldo
Copy link
Collaborator

Hi @MADNANTARRAR, please check the dev version of the docs for the most up-to-date version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenX Documentation [Bug]:
4 participants