-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add can_retire validation for multi-stage optimization #683
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we for sure don't want the "can retire" to flip values between stages? Any rationale in support of that?
The current multi-stage implementation utilizes the |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
The current implementation of multi-stage optimization doesn't allow a resource to switch from
can_retire = 0
tocan_retire = 1
between stages. This PR adds a validation check on thecan_retire
flag and throws an error if necessary.What type of PR is this? (check all applicable)
Checklist
How this can be tested
By running the multi-stage example with
can_retire = 0
for some resources instage = 1
, and then switching tocan_retire = 1
instage = 2
.Post-approval checklist for GenX core developers
After the PR is approved