-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refined DF Calculation in DDP for more general Expression for addressing variable length stages #680
Merged
sambuddhac
merged 18 commits into
GenXProject:release/0.4.0
from
sambuddhac:release/0.4.0
May 5, 2024
Merged
Refined DF Calculation in DDP for more general Expression for addressing variable length stages #680
sambuddhac
merged 18 commits into
GenXProject:release/0.4.0
from
sambuddhac:release/0.4.0
May 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix DF calculation in DDP to make it more generic for variable length stages
sambuddhac
changed the title
Release/0.4.0
Refined DF Calculation in DDP for more general Expression for addressing variable length stages
Apr 9, 2024
Added PR # in CHANGELOG.md
Update write_multi_stage_costs.jl with refined DF
Added a print statement reflecting the approximate value of costs for DDP
lbonaldo
reviewed
May 5, 2024
lbonaldo
reviewed
May 5, 2024
lbonaldo
reviewed
May 5, 2024
lbonaldo
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sambuddhac! Approved it with some comments.
Replaced println("**WARNING** : The cost calculation of the multi-stage GenX is approximate currently, and we will be refining it more in one of the future releases.") with @warn("The cost calculation of the multi-stage GenX is approximate currently, and we will be refining it more in one of the future releases.") Co-authored-by: Luca Bonaldo <[email protected]>
Removed print statement println("Value of stage len_1 in stage ", cur_stage, " is ", stage_len_1) Co-authored-by: Luca Bonaldo <[email protected]>
Replaced stage_len_1 with cum_years Co-authored-by: Luca Bonaldo <[email protected]>
Thanks, @lbonaldo . I have incorporated all your suggestions. And have made sure to check the integrity of the code. Now, merging this to release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines the evaluation of discount factor (DF) calculation in DDP making it more generic for variable length stages
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes Issue #671
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
Checklist
How this can be tested
Tested it against 6_three_zones_with_multistage
Post-approval checklist for GenX core developers
After the PR is approved