Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined DF Calculation in DDP for more general Expression for addressing variable length stages #680

Merged
merged 18 commits into from
May 5, 2024

Conversation

sambuddhac
Copy link
Collaborator

@sambuddhac sambuddhac commented Apr 9, 2024

Description

This PR refines the evaluation of discount factor (DF) calculation in DDP making it more generic for variable length stages

What type of PR is this? (check all applicable)

  • Bug Fix
  • Documentation Update

Related Tickets & Documents

Fixes Issue #671
https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Tested it against 6_three_zones_with_multistage

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@sambuddhac sambuddhac changed the title Release/0.4.0 Refined DF Calculation in DDP for more general Expression for addressing variable length stages Apr 9, 2024
Added PR # in CHANGELOG.md
Update write_multi_stage_costs.jl with refined DF
sambuddhac added 3 commits May 3, 2024 16:05
Added a print statement reflecting the approximate value of costs for DDP
Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sambuddhac! Approved it with some comments.

sambuddhac and others added 6 commits May 5, 2024 15:05
Replaced println("**WARNING** : The cost calculation of the multi-stage GenX is approximate currently, and we will be refining it more in one of the future releases.") with @warn("The cost calculation of the multi-stage GenX is approximate currently, and we will be refining it more in one of the future releases.")

Co-authored-by: Luca Bonaldo <[email protected]>
Removed print statement println("Value of stage len_1 in stage ", cur_stage, " is ", stage_len_1)

Co-authored-by: Luca Bonaldo <[email protected]>
Replaced stage_len_1 with cum_years

Co-authored-by: Luca Bonaldo <[email protected]>
@sambuddhac
Copy link
Collaborator Author

Thank you @sambuddhac! Approved it with some comments.

Thanks, @lbonaldo . I have incorporated all your suggestions. And have made sure to check the integrity of the code. Now, merging this to release branch.

@sambuddhac sambuddhac merged commit 13cbfa4 into GenXProject:release/0.4.0 May 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants