-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaler #667
Scaler #667
Conversation
PR for GenX v0.4.0 release from Release/0.4.0
Changed deploydoc URL to GenX.jl
With Zenodo badge
Update README.md
To render versioned doc pages along with dev and all three digits of the version number
With correct URL of doc pages in README
Update README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please mention a concrete example in which the ObjScale is something other than 1? I am failing to understand where exactly the current code-base is having problem? We already have a ParameterScale as @JesseJenkins mentioned in his response to the associated issue. In this PR you have kept the scaling factor to 1 and yet you mentioned in the description that the objective needs to be scaled. So, I am unable to understand. Have you tried using the ParameterScale that's already there in GenX?
@sambuddhac Yes, I have considered |
@nspatank I am assigning this to in order to respond. |
With modified scaler definition, mentioning that it addresses problem ill-conditioning
Description
Sometimes the model will be built into an ill form if some objective terms are quite large or small. To alleviate this problem, we could add a scaling factor to scale the objective function during solving while leaving all other expressions untouched. In example_systems/1_three_zones case, an example ObjScale of 10 could help to change the objective range from [1e-4, 6e+02] to [1e-3, 6e+03].
What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
How this can be tested
Add the setting key
ObjScale
with an appropriate value togenx_settings.yml
in any test cases. The objective function will be scaled accordingly.Post-approval checklist for GenX core developers
After the PR is approved