Get rid of costs to virtual charging & discharging in storage_all.jl #608

sambuddhac · 2024-01-08T19:56:10Z

Description

This PR minimizes the stray effect of virtual charging and discharging costs in storage_all.jl (Since virtual operations are theoretical and often lead to absurd outcomes).

What type of PR is this? (check all applicable)

Bug Fix
Performance Improvements

Related Tickets & Documents

Issue numbers fixed: Fixes Issue #604

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
Code has been tested to ensure all functionality works as intended.
CHANGELOG.md has been updated (if this is a 'notable' change).
I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Updated the test settings files by incorporating new settings parameter and modified objective function value for successful tests

Post-approval checklist for GenX core developers

After the PR is approved

Check that the latest changes on the target branch are incorporated, either via merge or rebase
Remember to squash and merge if incorporating into develop

cfe316 · 2024-01-08T20:01:20Z

Thanks, Sam.

It looks like VRE_STOR.jl lines 2036-2061 also has a virtual charging scheme.
This is mentioned in the comments/documentation there as well.

Please check that (the addition of virtual charge/discharge VOM costs to the Objective) is removed from any documentation as well.

sambuddhac · 2024-01-08T20:17:48Z

Thanks Jacob !!! Good catch. I will make sure that.

sambuddhac · 2024-01-13T01:04:06Z

@cfe316 @gmantegna @wilson-ricks @lbonaldo I need to modify the doc pages and also the automated test script a little. On to it. Would be helpful is any/some/all of you can review the code in the mean-time and see if I am doing the right things here. Thanks bunches !!!! 😃

lbonaldo · 2024-02-05T13:57:41Z

src/model/resources/vre_stor/vre_stor.jl

@@ -2034,28 +2035,28 @@ function vre_stor_capres!(EP::Model, inputs::Dict, setup::Dict)

    #Variable costs of DC "virtual charging" for technologies "y" during hour "t" in zone "z"
    @expression(EP, eCVar_Charge_DC_virtual[y in DC_CHARGE,t=1:T],
-        inputs["omega"][t]*by_rid(y,:Var_OM_Cost_per_MWh_Charge_DC)*vCAPRES_DC_CHARGE[y,t]/by_rid(y,:EtaInverter))
+        inputs["omega"][t]*(setup["VirtualChargeDischargeCost"]./scale_factor)*vCAPRES_DC_CHARGE[y,t]/by_rid(y,:EtaInverter))


You could define a new variable and then use it in all the expressions below (in this way, you would divide only once):

virtual_chargedischarge_cost = setup["VirtualChargeDischargeCost"] ./ scale_factor @expression(EP, eCVar_Charge_DC_virtual[y in DC_CHARGE,t=1:T], inputs["omega"][t]*(virtual_chargedischarge_cost * vCAPRES_DC_CHARGE[y,t]/by_rid(y,:EtaInverter))

lbonaldo

Thanks @sambuddhac for this PR! I just added a simple comment.

sambuddhac · 2024-02-05T15:13:37Z

Thanks @sambuddhac for this PR! I just added a simple comment.

Don't see your latest comment. Could you please write it here once again? Thanks !!!

cfe316 · 2024-02-05T22:29:11Z

CHANGELOG.md

@@ -38,6 +40,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fix access of eELOSSByZone expr before initialization (#541)
 - Correctly write unmet reserves (in reg_dn.csv) (#575)
 - Correctly scale total reserves column (in reg_dn.csv) (#594)
+- Fixes issue #604


It's useful to summarize what issue is being fixed here in the CHANGELOG, so that a user can understand whether it applied to their cases.

cfe316 · 2024-02-05T22:30:45Z

src/configure_settings/configure_settings.jl

@@ -9,6 +9,7 @@ function default_settings()
        "CapacityReserveMargin" => 0,
        "CO2Cap" => 0,
        "StorageLosses" => 1,
+        "VirtualChargeDischargeCost" => 1,


It would be useful to note here in a comment in that unlike the other the settings which are basically binary values, this thing has units of $/MWh.

cfe316 · 2024-02-05T22:31:45Z

src/model/resources/storage/storage_all.jl

@@ -32,6 +33,8 @@ function storage_all!(EP::Model, inputs::Dict, setup::Dict)
 	# Energy withdrawn from grid by resource "y" at hour "t" [MWh] on zone "z"
 	@variable(EP, vCHARGE[y in STOR_ALL, t=1:T] >= 0);

+	virtual_discharge_cost=setup["VirtualChargeDischargeCost"]./scale_factor


It's unclear why ./ is used since both the parameter and scale_factor are scalars.

cfe316 · 2024-02-05T22:34:06Z

Hi Sam, I've added a few comments about the code and about the changelog. Thanks.

I think also there needs to be a description of the new Settings parameter added to the documentation.

cfe316 · 2024-02-05T22:37:03Z

src/model/resources/storage/storage_all.jl

@@ -10,6 +10,7 @@ function storage_all!(EP::Model, inputs::Dict, setup::Dict)
 	dfGen = inputs["dfGen"]
 	Reserves = setup["Reserves"]
 	CapacityReserveMargin = setup["CapacityReserveMargin"]
+	scale_factor = setup["ParameterScale"] == 1 ? ModelScalingFactor : 1


It might be nice to think about loading this value in some other function, perhaps during load-time. In general, ModelScalingFactor and setup["ParameterScale"] are only referenced during the load_* and write_* phases, not during model construction. (The sole exception is in the hydrogen electrolyzer code.)

Perhaps this could be added to the inputs[] dictionary? @lbonaldo . Or added to each relevant resource, once that's done.

Yes, I think that would simplify the usage of the scaling factor. Something like:

inputs["scale_factor"] = setup["ParameterScale"] == 1 ? ModelScalingFactor : 1

in load_inputs, and then inside the functions we get the value from the inputs Dict?

scale_factor = inputs["scale_factor"]

That's a good idea! I was actually thinking of constructing the VirtualChargeDischargeCost at load time and sticking that in inputs!

Since virtual operations are theoretical and often lead to absurd outcomes.

With a new settings parameters, "VirtualChargeDischargeCost."

Update storage_all.jl with "VirtualChargeDischargeCost setting parameter to account for cost of virtual charging and discharging

With VOM replaced by setup["VirtualChargeDischargeCost"]

Added VirtualChargeDischargeCost settings parameter

Fix minor typos

Added consideration of model scaling to the virtual charge and discharge cost

Updated virtual charging and discharging with model scaling factors

Changed the value of the virtual charge discharge cost settings parameter to 1

…ding virtual charge discharge cost parameter

with virtual_discharge_cost=setup["VirtualChargeDischargeCost"]./scale_factor

With expression virtual_discharge_cost=setup["VirtualChargeDischargeCost"]./scale_factor

lbonaldo

This now looks good to me.

sambuddhac requested review from JesseJenkins, gmantegna and lbonaldo January 8, 2024 19:56

sambuddhac linked an issue Jan 8, 2024 that may be closed by this pull request

Variable costs should not be assigned to virtual storage charge/discharge #604

Closed

sambuddhac requested a review from cfe316 January 13, 2024 00:19

JesseJenkins mentioned this pull request Jan 29, 2024

Variable costs should not be assigned to virtual storage charge/discharge #604

Closed

lbonaldo reviewed Feb 5, 2024

View reviewed changes

cfe316 reviewed Feb 5, 2024

View reviewed changes

lbonaldo force-pushed the sambuddhac-patch-1 branch from 197404b to 9de4c8b Compare February 8, 2024 23:59

sambuddhac added 12 commits February 11, 2024 18:14

Get rid of costs to virtual charging & discharging in storage_all.jl

947762b

Since virtual operations are theoretical and often lead to absurd outcomes.

Update configure_settings.jl

e550efa

With a new settings parameters, "VirtualChargeDischargeCost."

Update storage_all.jl

292394b

Update storage_all.jl with "VirtualChargeDischargeCost setting parameter to account for cost of virtual charging and discharging

Update vre_stor.jl

43030e6

With VOM replaced by setup["VirtualChargeDischargeCost"]

Update test_VREStor.jl

91946a5

Added VirtualChargeDischargeCost settings parameter

Update vre_stor.jl

3b2826e

Fix minor typos

Update storage_all.jl

3602fd6

Added consideration of model scaling to the virtual charge and discharge cost

Update vre_stor.jl

a6b5381

Updated virtual charging and discharging with model scaling factors

Update configure_settings.jl

4c6a02a

Changed the value of the virtual charge discharge cost settings parameter to 1

Update test_VREStor.jl

77fe4d6

Changed the value of the virtual charge discharge cost settings parameter to 1

Modified objective value and edited settings in VREStor example inclu…

99908c9

…ding virtual charge discharge cost parameter

Updated CHANGELOG.md

befeb82

sambuddhac and others added 4 commits February 11, 2024 18:17

Update storage_all.jl

168388a

with virtual_discharge_cost=setup["VirtualChargeDischargeCost"]./scale_factor

Update vre_stor.jl

6d71f53

With expression virtual_discharge_cost=setup["VirtualChargeDischargeCost"]./scale_factor

Add virtual_discharge_cost to inputs Dict

38161a7

Update docs

c2ce35b

lbonaldo force-pushed the sambuddhac-patch-1 branch from 3258524 to c2ce35b Compare February 11, 2024 23:20

Update CHANGELOG.md

ded2cd4

lbonaldo self-requested a review February 11, 2024 23:40

lbonaldo approved these changes Feb 11, 2024

View reviewed changes

lbonaldo merged commit b2b3987 into develop Feb 11, 2024
9 checks passed

lbonaldo deleted the sambuddhac-patch-1 branch February 11, 2024 23:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get rid of costs to virtual charging & discharging in storage_all.jl #608

Get rid of costs to virtual charging & discharging in storage_all.jl #608

sambuddhac commented Jan 8, 2024 •

edited by lbonaldo

Loading

cfe316 commented Jan 8, 2024 •

edited

Loading

sambuddhac commented Jan 8, 2024

sambuddhac commented Jan 13, 2024

lbonaldo Feb 5, 2024

sambuddhac Feb 5, 2024

lbonaldo left a comment

sambuddhac commented Feb 5, 2024

cfe316 Feb 5, 2024 •

edited

Loading

cfe316 Feb 5, 2024

cfe316 Feb 5, 2024

cfe316 commented Feb 5, 2024

cfe316 Feb 5, 2024 •

edited

Loading

cfe316 Feb 5, 2024

lbonaldo Feb 7, 2024

cfe316 Feb 7, 2024

lbonaldo left a comment

Get rid of costs to virtual charging & discharging in storage_all.jl #608

Get rid of costs to virtual charging & discharging in storage_all.jl #608

Conversation

sambuddhac commented Jan 8, 2024 • edited by lbonaldo Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

How this can be tested

Post-approval checklist for GenX core developers

cfe316 commented Jan 8, 2024 • edited Loading

sambuddhac commented Jan 8, 2024

sambuddhac commented Jan 13, 2024

lbonaldo Feb 5, 2024

Choose a reason for hiding this comment

sambuddhac Feb 5, 2024

Choose a reason for hiding this comment

lbonaldo left a comment

Choose a reason for hiding this comment

sambuddhac commented Feb 5, 2024

cfe316 Feb 5, 2024 • edited Loading

Choose a reason for hiding this comment

cfe316 Feb 5, 2024

Choose a reason for hiding this comment

cfe316 Feb 5, 2024

Choose a reason for hiding this comment

cfe316 commented Feb 5, 2024

cfe316 Feb 5, 2024 • edited Loading

Choose a reason for hiding this comment

cfe316 Feb 5, 2024

Choose a reason for hiding this comment

lbonaldo Feb 7, 2024

Choose a reason for hiding this comment

cfe316 Feb 7, 2024

Choose a reason for hiding this comment

lbonaldo left a comment

Choose a reason for hiding this comment

sambuddhac commented Jan 8, 2024 •

edited by lbonaldo

Loading

cfe316 commented Jan 8, 2024 •

edited

Loading

cfe316 Feb 5, 2024 •

edited

Loading

cfe316 Feb 5, 2024 •

edited

Loading