Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUST_RUN units have uncapped reserves #576

Closed
cfe316 opened this issue Nov 11, 2023 · 5 comments
Closed

MUST_RUN units have uncapped reserves #576

cfe316 opened this issue Nov 11, 2023 · 5 comments
Assignees
@cfe316 @lbonaldo
Labels
bug Something isn't working
Milestone
v0.4

Comments

@cfe316
Copy link
Collaborator

cfe316 commented Nov 11, 2023 •
edited
Loading

If the user enters Reg_Max > 0 or Rsv_Max > 0, these units will be part of REG or RSV, respectively. However, there are no constraints on vRSV or vREG for these units.

This is currently the case for RealSystemExample/ISONE_Trizone, which is the only example with Reserves=1.
@cfe316 cfe316 added the bug Something isn't working label Nov 11, 2023
@cfe316
Copy link
Collaborator Author

cfe316 commented Nov 12, 2023

This is no longer the case for that example, on the develop branch, as of #577.

@cfe316 cfe316 added this to the v0.4 milestone Dec 13, 2023
@cfe316
Copy link
Collaborator Author

cfe316 commented Dec 19, 2023

In general we should add a check that MUST_RUN units can never contribute to reserves.

  • upon loading a MUST_RUN unit, check that Reg_Max, Rsv_Max are zero, or throw an error.

@JesseJenkins
Copy link
Collaborator

@lbonaldo can you please push #577 fix to the Main to close this bug.

@lbonaldo lbonaldo mentioned this issue Feb 1, 2024
Merged
@lbonaldo
Copy link
Collaborator

lbonaldo commented Feb 1, 2024

This should be fixed in Main since MUST_RUN units were added to RealSystemExample with 852cf37, which is still in develop. I created a PR targeting develop to validate MUST_RUN resources and fix this bug.

lbonaldo added a commit that referenced this issue Feb 1, 2024
@lbonaldo
Fix #576: validate MUST_RUN reserve contribution (#619)
6e6f3bf 
Add a validation check that MUST_RUN units have Reg_Max and Rsv_Max 
set to zero in Generators_data.csv.
@lbonaldo
Copy link
Collaborator

lbonaldo commented Feb 1, 2024

Fixed in #619.

@lbonaldo lbonaldo closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfe316 cfe316

@lbonaldo lbonaldo

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
3 participants
@cfe316 @JesseJenkins @lbonaldo