Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet reserves are not output correctly #575

Closed
cfe316 opened this issue Nov 11, 2023 · 2 comments
Closed

Unmet reserves are not output correctly #575

cfe316 opened this issue Nov 11, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cfe316
Copy link
Collaborator

cfe316 commented Nov 11, 2023

write_rsv.jl has unmet_vec[RSV] = value.(EP[:vUNMET_RSV][RSV])
where RSV = inputs["RSV"]
but vUNMET_RSV is a 1D array indexed by time, not generator / R_ID.

@cfe316 cfe316 added the bug Something isn't working label Nov 11, 2023
@sambuddhac
Copy link
Collaborator

This is now fixed on develop with this code modification

rsv[RSV, :] = value.(EP[:vRSV][RSV, :]) * scale_factor
unmet_vec = value.(EP[:vUNMET_RSV]) * scale_factor

@cfe316 Jacob and @JesseJenkins ... I think this issue is good to be closed now?

@cfe316
Copy link
Collaborator Author

cfe316 commented Jan 22, 2024

Yes, we can close it.

@cfe316 cfe316 closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants