Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investment cost in NetRevenue.csv results output incorrect for retro generators #570

Closed
ASamarkRoth opened this issue Nov 2, 2023 · 4 comments · Fixed by #600
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ASamarkRoth
Copy link

If I understand correctly, generators with RETRO==1 should see investment costs according to Retro1_Inv_Cost_per_MWyr and not Inv_Cost_per_MWyr. This needs to be handled when writing NetRevenue.csv output: https://github.com/GenXProject/GenX/blob/5ccb3cab4b60c20fd40e45150a7f54133bb7304a/src/write_outputs/write_net_revenue.jl#L18

For users facing this issue, also applying Retro1_Inv_Cost_per_MWyr to Inv_Cost_per_MWyr would render expected costs in NetRevenue.csv. However, this will not work in the case of multiple sources for the retrofit with different values of Retro{n}_Inv_Cost_per_MWyr.

@cfe316
Copy link
Collaborator

cfe316 commented Nov 2, 2023

Hi Anton,

Retrofits is currently an experimental feature, and should not have been included on the main branch; in fact we will gate it behind a warning that says so during the next update.

Thank you for raising these issues. If you have ideas on how to fix this, you are welcome to submit a pull request.

@ASamarkRoth
Copy link
Author

Thanks for your reply!

Will keep this on our mind as we continue on our development!

@JesseJenkins JesseJenkins added the bug Something isn't working label Jan 8, 2024
@JesseJenkins
Copy link
Collaborator

@lbonaldo please confirm that the retrofit feature to be merged into develop (for v0.4 release) addresses this bug and if so, close issue.

@GenXProject GenXProject added this to the v0.4 milestone Feb 4, 2024
@lbonaldo lbonaldo linked a pull request Mar 18, 2024 that will close this issue
@lbonaldo
Copy link
Collaborator

Hi Anton,

We've merged the new retrofit module (#600) which should address this issue. I've gone ahead and closed it, but please don't hesitate to reopen it if needed.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants