Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eELOSSByZone expr: access before initialization #569

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

lbonaldo
Copy link
Collaborator

Description

This closes #541.
The expression eELOSSByZone is accessed in co2_cap.jl without being initialized if no storage is present in the model.

What type of PR is this? (check all applicable)

  • Bug Fix

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated.
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Run Example_Systems/SmallNewEngland/OneZone/Run.j.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@lbonaldo lbonaldo requested a review from cfe316 October 28, 2023 19:51
Copy link
Collaborator

@cfe316 cfe316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving; not sure if you want to merge or squash it to main.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #569 (d7de540) into main (ae19f20) will increase coverage by 0.22%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #569      +/-   ##
========================================
+ Coverage   0.07%   0.30%   +0.22%     
========================================
  Files        112     112              
  Lines       3800    3931     +131     
========================================
+ Hits           3      12       +9     
- Misses      3797    3919     +122     
Files Coverage Δ
src/model/generate_model.jl 0.00% <0.00%> (ø)
src/model/resources/storage/storage_all.jl 0.00% <0.00%> (ø)

... and 40 files with indirect coverage changes

@lbonaldo lbonaldo merged commit 73a497c into GenXProject:main Oct 30, 2023
2 of 4 checks passed
@lbonaldo lbonaldo deleted the hotfix-541 branch November 6, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's an issue when the CO2 cap is set to 2, but the file "generator_data.csv" does not have storage.
2 participants