Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electrolyzers should report their electricity use by zone in power_balance #559

Closed
cfe316 opened this issue Oct 9, 2023 · 2 comments
Closed

Electrolyzers should report their electricity use by zone in power_balance #559

cfe316 opened this issue Oct 9, 2023 · 2 comments
Assignees
@sambuddhac @lbonaldo
Labels
bug Something isn't working
Milestone
v0.4

Comments

@cfe316
Copy link
Collaborator

cfe316 commented Oct 9, 2023

In write_power_balance.jl, all electrolyzers report their power consumption as if it were in every zone.

		if (!isempty(ELECTROLYZER))
			powerbalance[(z-1)*L+11, :] = (-1) * sum(value.(EP[:vUSE][ELECTROLYZER, :].data), dims = 1)
		end

need something like ELECTROLYZER_ZONE = intersect(dfGen[dfGen.Zone.==z, :R_ID], ELECTROLYZER).
@cfe316 cfe316 added the bug Something isn't working label Oct 9, 2023
@cfe316 cfe316 added this to the v0.4 milestone Oct 9, 2023
@cfe316
Copy link
Collaborator Author

cfe316 commented Dec 5, 2023

This is now fixed on develop.

cfe316 added a commit that referenced this issue Dec 5, 2023
@cfe316
Fix #559: report electrolyzer power per-zone (#596)
090fecc 
Previously, electrolyzers reported their power as if they were in every zone.
@sambuddhac
Copy link
Collaborator

PR #596 fixed this on develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambuddhac sambuddhac

@lbonaldo lbonaldo

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4
Development

No branches or pull requests
3 participants
@sambuddhac @cfe316 @lbonaldo