Maintenance constraints (and for thermal generators) #556

cfe316 · 2023-10-02T00:06:59Z

This adds the ability to have maintenance constraints for arbitrary generators that have

a COMMIT-like quantity
a eTotalCap-like quantity
a Cap_Size-like quantity

I've implemented this in a very general way:

The maintenance variables are given custom names per-resource (with an optional suffix). This potentially allows for more than one component of a complex resource to have maintenance, on different schedules.
So far I've "implemented" maintenance variables for THERM generators only.
I plan to apply these to fusion core

This adds 4 optional columns to Generators_data.csv:
MAINT, Maintenance_Duration, Maintenance_Frequency_Years and Maintenance_Begin_Cadence.
The first is either 0/1. The others are not read for a given resource unless it has MAINT=1.
The MAINT column as a whole is optional.

This outputs a new file called maint_down.csv. This tracks the number of plants (in units of Cap_Size) which are under maintenance in each timestep.
I have yet to write documentation for this module.
I'd appreciate any critiques on code style, inconsistent or annoying variable names, etc.
This should be applied before the general Fusion/Thermal+Storage module Thermal+storage (fusion, maintenance) #546 , which will be edited accordingly.

No effects on CapResMargin re: COMMIT status

gmantegna

Looks good overall. A couple of comments and requests:

Please add documentation to the docs for the new inputs and also the added functionality.
Do the maintenance constraints make sense when TDR is used?
Confirming that all the units make sense when unit commitment is not integer?
How does this play with operating reserves? In the current formulation, can a plant provide operating reserves when it is on maintenance?

src/model/resources/maintenance.jl

gmantegna · 2023-10-02T17:46:56Z

src/model/resources/maintenance.jl

+    @constraint(EP, [t in T], vMDOWN[t] == sum(vMSHUT[controlling_hours(t)]))
+
+    # Plant frequire maintenance every (certain number of) year(s)
+    @constraint(EP, sum(vMSHUT[t]*weights[t] for t in maintenance_begin_hours) >=


how does this work when you are only modeling one year?

Yeah, maybe it's pointless to have weights here.

In general

maintenance only works when you are modeling one year

if a plant requires maintenance every N years then 1/N of the plants require maintenance.

src/model/resources/thermal/thermal.jl

gmantegna · 2023-10-02T17:53:07Z

src/model/resources/maintenance.jl

+const MAINTENANCESHUTVARS = "MaintenanceShutVariables"
+const HASMAINT = "has_maiNTENANCE"
+
+function get_maintenance(df::DataFrame)::Vector{Int}


Please provide more documentation for these functions.

src/model/resources/maintenance.jl

cfe316 · 2023-10-03T16:35:40Z

Do the maintenance constraints make sense when TDR is used?

No, and the code will throw an error. It is required that inputs["REP_PERIOD"]==1.

Confirming that all the units make sense when unit commitment is not integer?

Yes, that should be fine. We interface with vCOMMIT (which is always measured in 'number of plants') and eTotalCap (which is always measured in 'power' (i.e. MW)). It's only vCAP which is sometimes one and sometimes the other.

How does this play with operating reserves? In the current formulation, can a plant provide operating reserves when it is on maintenance?

Operating reserves require vCOMMIT'd units. The maintenance formulation pushes down to limit the maximum vCOMMIT:
@constraint(EP, [t in T], ecap[y] / cap - vcommit[y, t] >= vMDOWN[t])

Still need to do docs. Might to a separate User docs and Developer docs.

cfe316 · 2023-10-03T22:40:15Z

Requesting a second review.

Possible todos:

[ ] Mathematical formulation (is there any interest for this?) Any suggestions for variable names in model_notation.md?
[ ] Minimal test case

Please read over maintenance.md; I think it's explained pretty well.

gmantegna

Couple of minor documentation suggestions otherwise looks good.

gmantegna · 2023-10-03T23:58:13Z

docs/src/data_documentation.md

@@ -388,6 +389,11 @@ This file contains cost and performance parameters for various generators and ot
 |PWFU\_Fuel\_Usage\_Zero\_Load\_MMBTU\_per\_h|The fuel usage (MMBTU/h) for the first PWFU segemnt (y-intercept) at zero load.|
 |PWFU\_Heat\_Rate\_MMBTU\_per\_MWh\_*i| The slope of fuel usage function of the segment i.|
 |PWFU\_Load\_Point\_MW\_*i| The end of segment i (MW).|
+|**Maintenance data**|
+|MAINT|[0,1], toggles scheduled maintenance formulation.|


suggests saying "constraints" instead of "formulation"

I don't want to only call it "constraints" because it includes new variables as well.

gmantegna · 2023-10-03T23:58:59Z

docs/src/data_documentation.md

+|MAINT|[0,1], toggles scheduled maintenance formulation.|
+|Maintenance\_Duration| Duration of the maintenance period, in number of timesteps. Only used if `MAINT=1`.|
+|Maintenance\_Frequency\_Years| (Inverse) frequency of scheduled maintenance, in years. Only used if `MAINT=1`.|
+|Maintenance\_Begin\_Cadence| Cadence of timesteps in which scheduled maintenance can begin. Only used if `MAINT=1`.|


It's unclear to me what this means. Suggest adding more explanation.

I see you explain it below but would suggest having just a bit more explanation here so it can stand on its own.

docs/src/maintenance.md

gmantegna · 2023-10-04T00:03:30Z

docs/src/maintenance.md

+- More than a single maintenance period per year (i.e. every three months) is not possible in the current formulation.
+- Only full-year cases can be run; there must be only one "representative period".
+It would not make sense to model a *month*-long maintenance period when the year is modeled as a series of representative *weeks*, for example.
+- Multi-stage has not yet been tested (but please let us know what happens if you test it!).


Not sure if this is appropriate for documentation. Maybe we should ask someone to test this, at least just a quick sanity check.

I tested it and it seemed to work.

gmantegna · 2023-10-04T00:04:40Z

docs/src/maintenance.md

+- Multi-stage has not yet been tested (but please let us know what happens if you test it!).
+
+### Interaction with integer unit commitment
+If integer unit commitment is on (`UCommit=1`), this module may not produce sensible results.


I think this paragraph could be worded more clearly. I understand what you're saying after reading it a few times but it's not super clear.

src/model/resources/maintenance.jl

lbonaldo

Thanks for the PR and for including all the comments. Looks great to me.

Maintenance_Frequency_Years to Maintenance_Cycle_Length_Years Frequencies have units of inverse-time. This is quantity with units of time. I have corrected the name.

Add an optional formulation for scheduled maintenance. Plants with this formulation active (so far, limited to thermal-commit plants, THERM=1) need to undergo a certain number of contiguous hours of maintenance every y >= 1 years. During this time they produce no power. This may be particularly useful in modeling fission plants, which need roughly 4 weeks of maintenance every 18 or 24 months. (Here, 18 would need to be rounded up to 24, as only maintenance cycles which are an integer number of years work with this formulation.)

cfe316 added 2 commits October 1, 2023 19:17

Initial maintenance constraints

ffd278d

No effects on CapResMargin re: COMMIT status

Add capacity reserve margin effect

866c2b4

cfe316 requested review from gmantegna and lbonaldo October 2, 2023 00:08

gmantegna requested changes Oct 2, 2023

View reviewed changes

cfe316 added 7 commits October 3, 2023 10:22

fix capitaLIZATION

bea9f3f

Update_to_JuMP_Style

56259fb

Rename reserves to ncapres, etc

5b6435b

Remove weights

73b962a

typo

cc62c2e

Apply JuliaFormatter

cd8741c

Use named constant key

5017fa0

cfe316 added 15 commits October 3, 2023 13:06

Simplify implementation

d137c06

Use a common name for a collection

0027091

Simplify formulation

c623d83

Add docstrings for methods

bbf20c9

Add docstrings

b5cbbf1

Add validation

38e0d15

Fix name

603274f

More verbose resource checking

34b7130

Start adding docs

1c2c1af

Write maintenance docs

ab6515a

Add developer docs

c130ae1

Improve docs

a62a54a

Improve docs

6cce768

Add data documentation for inputs

6c1d3aa

Add description of output file.

50a19c9

Simplify constraints

b223f89

gmantegna approved these changes Oct 4, 2023

View reviewed changes

cfe316 marked this pull request as ready for review October 4, 2023 02:45

cfe316 added 2 commits October 3, 2023 22:54

Address comments

b8e4578

Address comments

84d5f4c

lbonaldo approved these changes Oct 4, 2023

View reviewed changes

cfe316 added 5 commits October 4, 2023 14:26

Add maintenance to doc tree

6e28936

Typo

391bb1e

Better explanation

6776b14

Change maintenance column name

b52fa38

Maintenance_Frequency_Years to Maintenance_Cycle_Length_Years Frequencies have units of inverse-time. This is quantity with units of time. I have corrected the name.

Changelog

af5c32e

cfe316 merged commit a1475c7 into GenXProject:develop Oct 4, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maintenance constraints (and for thermal generators) #556

Maintenance constraints (and for thermal generators) #556

cfe316 commented Oct 2, 2023 •

edited

Loading

gmantegna left a comment •

edited

Loading

gmantegna Oct 2, 2023

cfe316 Oct 3, 2023

gmantegna Oct 2, 2023

cfe316 commented Oct 3, 2023 •

edited

Loading

cfe316 commented Oct 3, 2023

gmantegna left a comment

gmantegna Oct 3, 2023

cfe316 Oct 4, 2023

gmantegna Oct 3, 2023

gmantegna Oct 4, 2023

gmantegna Oct 4, 2023

cfe316 Oct 4, 2023

gmantegna Oct 4, 2023

lbonaldo left a comment

Maintenance constraints (and for thermal generators) #556

Maintenance constraints (and for thermal generators) #556

Conversation

cfe316 commented Oct 2, 2023 • edited Loading

gmantegna left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cfe316 commented Oct 3, 2023 • edited Loading

cfe316 commented Oct 3, 2023

gmantegna left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lbonaldo left a comment

Choose a reason for hiding this comment

cfe316 commented Oct 2, 2023 •

edited

Loading

gmantegna left a comment •

edited

Loading

cfe316 commented Oct 3, 2023 •

edited

Loading