-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thermal+storage (fusion, maintenance) #546
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except for the capacity reserve margin constraint
Not all variables have 1:T indices now, particularly vFMSHUT. Get the correct set of indices rather than assuming.
It makes a problem with only one TS plant infeasible.
Codecov Report
@@ Coverage Diff @@
## develop #546 +/- ##
==========================================
+ Coverage 0.07% 0.26% +0.18%
==========================================
Files 112 115 +3
Lines 3800 4562 +762
==========================================
+ Hits 3 12 +9
- Misses 3797 4550 +753
|
cfe316
force-pushed
the
thermstor_v0.3.6
branch
from
September 14, 2023 01:37
91ff871
to
0ff3070
Compare
This now should properly cancel eTotalCap, at least for units without storage.
Closing because this is not ready, and will need to be substantially reworked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request, just to show everyone what might should be coming down the pipeline soon. The branch is currently based on v0.3.6, not on develop, so that why I've done it this way for now.
I am pretty happy with how I wrote up the formulation
thermal_storage.jl
. There are some new techniques here.I'm also happy with the more simplified output files as seen in
write_thermal_storage.jl
.TBD: