Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LDES period references consistent with standard storage #522

Open
gmantegna opened this issue Aug 14, 2023 · 2 comments
Open

Make LDES period references consistent with standard storage #522

gmantegna opened this issue Aug 14, 2023 · 2 comments
Assignees
@cfe316 @lbonaldo
Labels
enhancement New feature or request

Comments

@gmantegna
Copy link
Collaborator

Currently, storage_all.jl uses functions like "hoursbefore" to do period wrapping whereas long_duration_storage.jl uses harder to read expressions like "hours_per_subperiod*(w-1)+1". The LDES constraints could be made easier to read and work with if they were modified to at least abstract out what these expressions mean, or ideally use a function like storage_all.jl does. cc @cfe316
@JesseJenkins JesseJenkins added the enhancement New feature or request label Jan 8, 2024
@JesseJenkins
Copy link
Collaborator

@lbonaldo @sambuddhac has this been fixed in v0.4? If not, please address when practical.

@sambuddhac
Copy link
Collaborator

@lbonaldo @sambuddhac has this been fixed in v0.4? If not, please address when practical.

Nope !!! This hasn't been done yet. But, happy to take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfe316 cfe316

@lbonaldo lbonaldo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sambuddhac @cfe316 @JesseJenkins @gmantegna @lbonaldo