Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image preloading state #11

Open
piperhaywood opened this issue Aug 28, 2019 · 5 comments
Open

Image preloading state #11

piperhaywood opened this issue Aug 28, 2019 · 5 comments
Assignees
Labels
concern: visual-design Relating to the visual design

Comments

@piperhaywood
Copy link
Collaborator

piperhaywood commented Aug 28, 2019

eFlux has a neat loading pattern that @GemCopeland is interested in:

We discussed the approach used on e-flux, which loads a simple ASCII pattern first before loading the images. They have a separate source for this patterned background.

Medium as well. Medium loads a tiny thumbnail which they scale up and blur with CSS, replacing with the large image when it’s loaded.

We’ll probably go down the eFlux route due to #12.

Current possibilities include small tiled background images, CSS patterns, and gradient backgrounds. The last is probably the one we’re most excited about currently. Would probably use the two main site colours initially and as an enhancement, allow @GemCopeland to choose the colours on an image-by-image basis.

Any of this functionality would probably require a slightly modified Markdown parser since at minimum, we would need the output to be something like:

<img class="lazyload" alt="This is the alt" data-src="https://gemmacope.land/image.jpg" width="300" height="200">

Perhaps consider the way that Kirby handles images in Kirbytext (read more). The syntax for the above would be:

(image: https://gemmacope.land/image.jpg alt: This is the alt width: 300 height: 200 imgclass: lazyload)

Of course, Markdown does support HTML markup so perhaps it’s worth keeping that in mind for the initial version.

@piperhaywood piperhaywood added missing: discussion Needs a bit of further discussion concern: visual-design Relating to the visual design labels Aug 28, 2019
@piperhaywood piperhaywood added this to the Getting started milestone Aug 28, 2019
@GemCopeland
Copy link
Owner

Going to go with a purple gradient to begin with, potentially moving as it loads. Gemma to look at how this would animate.

Going to go with the Kirbytext approach to images.

@GemCopeland GemCopeland removed the missing: discussion Needs a bit of further discussion label Aug 30, 2019
@GemCopeland GemCopeland changed the title Decide on best image loading behaviour Design image preloading state Aug 30, 2019
@piperhaywood piperhaywood removed this from the v0.1 – First build milestone Sep 26, 2019
@piperhaywood piperhaywood changed the title Design image preloading state Image preloading state Sep 26, 2019
@piperhaywood
Copy link
Collaborator Author

@GemCopeland Let’s review this together, want to be sure I understand what you’re going for from the designs!

@piperhaywood piperhaywood added the missing: discussion Needs a bit of further discussion label Sep 26, 2019
@piperhaywood piperhaywood self-assigned this Sep 26, 2019
@piperhaywood piperhaywood added this to the v0.2 milestone Sep 26, 2019
@piperhaywood
Copy link
Collaborator Author

@GemCopeland to choose a bunch of unicode symbols for use in bg of loading images. Once chosen, pass issue back to @piperhaywood so that I can implement them in the global.json file

@piperhaywood
Copy link
Collaborator Author

Related to #15 and #17

@piperhaywood piperhaywood removed their assignment Oct 21, 2019
@piperhaywood piperhaywood removed the missing: discussion Needs a bit of further discussion label Oct 21, 2019
@GemCopeland
Copy link
Owner

Selected symbols for preloader patterns:






















@piperhaywood piperhaywood modified the milestones: v0.2, v0.3 Nov 4, 2019
@piperhaywood piperhaywood removed this from the v0.3 milestone Nov 13, 2019
@piperhaywood piperhaywood added this to the v1.1 milestone Nov 20, 2019
@piperhaywood piperhaywood removed this from the v1.1 milestone Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concern: visual-design Relating to the visual design
Projects
None yet
Development

No branches or pull requests

2 participants