Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand peer dependencies #88

Open
Techn1x opened this issue Dec 5, 2023 · 4 comments · May be fixed by #90
Open

Expand peer dependencies #88

Techn1x opened this issue Dec 5, 2023 · 4 comments · May be fixed by #90

Comments

@Techn1x
Copy link

Techn1x commented Dec 5, 2023

Would be great to expand these eg "ember-basic-dropdown": "^6.0.1 || ^7",

└─┬ @gavant/glint-template-types 0.3.6
  ├── ✕ unmet peer ember-basic-dropdown@^6.0.1: found 7.3.0
  └── ✕ unmet peer ember-modifier@^3.2.7: found 4.1.0

pnpm is quite strict with peer deps (unless that is turned off, which I don't want to do, as I'm using this in an addon/package and it's advised to keep it strict there)

Probably a few others to update as well

"peerDependencies": {
"ember-animated": "^1.0.0",
"ember-basic-dropdown": "^6.0.1",
"ember-concurrency": "^2.0.3",
"ember-concurrency-async": "^1.0.0",
"ember-concurrency-ts": "^0.3.0",
"ember-intl": "^5.7.2",
"ember-modifier": "^3.2.7",
"ember-power-select": "^5.0.0",
"ember-source": "^3.28.0 || ^4.0.0 || ^5.0.0"

@elidupuis
Copy link

I just ran into this issue after upgrading to ember-intl v6. I've update my type registry based on the details in the ember-intl migration guide but I'm still getting the following error after running npm install:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @gavant/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/ember-intl
npm ERR!   dev ember-intl@"^6.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional ember-intl@"^5.7.2" from @gavant/[email protected]
npm ERR! node_modules/@gavant/glint-template-types
npm ERR!   dev @gavant/glint-template-types@"^0.4.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/ember-intl
npm ERR!   peerOptional ember-intl@"^5.7.2" from @gavant/[email protected]
npm ERR!   node_modules/@gavant/glint-template-types
npm ERR!     dev @gavant/glint-template-types@"^0.4.0" from the root project

@bakerac4 Would simply expanding the dependency range for these optional packages solve this issue? Happy to open a PR if this is the case.

elidupuis added a commit to elidupuis/glint-template-types that referenced this issue Feb 14, 2024
This should allow apps to use newer versions of these addons and avoid
package manager validation errors.

Closes Gavant#88.
@elidupuis elidupuis linked a pull request Feb 14, 2024 that will close this issue
@Techn1x
Copy link
Author

Techn1x commented Feb 14, 2024

What's a little annoying is that types from this package aren't needed for ember-intl v6 and various other addons once they're updated.

I think another solution here, is for those addons that do indeed have template types now, to remove them from this package. Cut a major, drop those types and dependencies, and tell those consumers to update to a later version of ember-intl, ember-concurrency, etc. to get the real template types.

@elidupuis
Copy link

What's a little annoying is that types from this package aren't needed for ember-intl v6 and various other addons once they're updated.

Yes, exactly!

I opened #90 and it seems to "fix" the issue for my case. But I agree that addons with first class type support should probably be removed from glint-template-types 👍

@Techn1x
Copy link
Author

Techn1x commented Jun 28, 2024

Doesn't look like this repo is seeing much help, which I guess is OK, it's only intended as a stop-gap and should go away over time. I only needed FaIcon and ModalDialog types from this package, so I've gone ahead and copied them into my repo and dropped gavant template types. Now I can have strict pnpm peers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants