-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand peer dependencies #88
Comments
I just ran into this issue after upgrading to
@bakerac4 Would simply expanding the dependency range for these optional packages solve this issue? Happy to open a PR if this is the case. |
This should allow apps to use newer versions of these addons and avoid package manager validation errors. Closes Gavant#88.
What's a little annoying is that types from this package aren't needed for ember-intl v6 and various other addons once they're updated. I think another solution here, is for those addons that do indeed have template types now, to remove them from this package. Cut a major, drop those types and dependencies, and tell those consumers to update to a later version of ember-intl, ember-concurrency, etc. to get the real template types. |
Yes, exactly! I opened #90 and it seems to "fix" the issue for my case. But I agree that addons with first class type support should probably be removed from |
Doesn't look like this repo is seeing much help, which I guess is OK, it's only intended as a stop-gap and should go away over time. I only needed FaIcon and ModalDialog types from this package, so I've gone ahead and copied them into my repo and dropped gavant template types. Now I can have strict pnpm peers 👍 |
Would be great to expand these eg
"ember-basic-dropdown": "^6.0.1 || ^7",
pnpm is quite strict with peer deps (unless that is turned off, which I don't want to do, as I'm using this in an addon/package and it's advised to keep it strict there)
Probably a few others to update as well
glint-template-types/package.json
Lines 53 to 62 in 32f273d
The text was updated successfully, but these errors were encountered: