Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely hide collapsed table rows #8

Open
billdami opened this issue Jul 27, 2020 · 0 comments
Open

Completely hide collapsed table rows #8

billdami opened this issue Jul 27, 2020 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@billdami
Copy link
Member

billdami commented Jul 27, 2020

When using the expandable rows component, a row's "expanded content" <tr> should ideally either be not rendered at all, or at the very least have a style or class on it that gives it display:none. There appears to be issues in glimmer preventing the first solution (not rendering it at all), and issues in <VerticalCollection> preventing the second solution (applying a style/class):

html-next/vertical-collection#247
html-next/vertical-collection#299

The error message mentioned in the above linked issues crops up when using the style/class solution and the user is expanding rows and then quickly scrolling a fair amount up and down the table, possibly only when quickly scrolling (usually pagination needs to be occurring for it to manifest as well).

If either issue is fixed, we should update this functionality accordingly.

@billdami billdami added bug Something isn't working help wanted Extra attention is needed labels Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant