Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width and Height need to support percentage value #7

Open
diondirza opened this issue Sep 23, 2016 · 1 comment
Open

Width and Height need to support percentage value #7

diondirza opened this issue Sep 23, 2016 · 1 comment
Assignees

Comments

@diondirza
Copy link

Hi,

Seems your component support percentage value for its width and height, yet its still give warning that number expected instead of string. Should use PropTypes.oneOfType in your component instead just PropTypes.number

@jasan-s
Copy link

jasan-s commented Oct 29, 2016

facing the same warnings, but I don't beleieve the component supports height and width values as percentages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants