Add flake to support building via nix. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langston-barrett
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Nice! The following general comments can be addressed in this PR or we can merge this and make follow-up issues:
- Can we add a shell to the flake and delete
shell.nix? - I understand that the tests aren't quite passing yet. Let's make an issue tracking this.
- Can we run a build with Nix in CI? If it takes much longer than the normal build, perhaps we could run it just on the main branch.
Done. I did not delete the
We can; I will add that separately. I don't think it'll be much shorter, despite nix caching, because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.