Dm/desync #359
Merged
Dm/desync #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… output This resolves an issue where matches would fail against nodes with output that was too long, causing the pretty-printer to insert newlines and thus no longer matching the string in the script.
Wraps the int-prefixed parser in "try" (i.e. trying to match 'N:') so that it can backtrack when the ':' token is not found and fallthrough to parsing it as just a string. Needed to allow string queries that start with hex values
When the graph node for a synchronization point is created, it now inherits the calling context of the desync point, rather than dropping it.
Script files are not used for self-equivalence tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: adding desync/sync point tests and fixing issue with providing desync points