Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86-symbolic: Index definitions for remaining registers #443

Merged
merged 6 commits into from
Sep 24, 2024
Merged

x86-symbolic: Index definitions for remaining registers #443

merged 6 commits into from
Sep 24, 2024

Conversation

langston-barrett
Copy link
Contributor

@langston-barrett langston-barrett commented Sep 24, 2024 •
edited
Loading

  • Adds type synonyms for the indices of each named register in the ArchRegContext
  • Redefines register Indexes using natIndex, simplifying them considerably
  • Adds the FLAGS register components
  • Adds the x87 status register components
  • Fixes a bug in the x86RegName' for x87 status registers
  • Moves register-related definitions to their own module
  • Adds Index definitions for remaining registers: st*, zmm*

@langston-barrett langston-barrett self-assigned this Sep 24, 2024
Your Name added 3 commits September 24, 2024 13:39
x86-symbolic: Split out registers into their own module
a022c2b
x86-symbolic: Remove terse register names from top-level exports
896d35c 
These names are so short that they might conflict with local names in
files that import this module. Instead, export them from `Regs` and
encourage qualified use of that module.
x86-symbolic: Indexes for the remaining registers
f4f1e1f
@langston-barrett langston-barrett changed the title x86-symbolic: Register Index definitions for flags, x87 status registers x86-symbolic: Index definitions for remaining registers Sep 24, 2024
@langston-barrett langston-barrett marked this pull request as ready for review September 24, 2024 18:30
RyanGlScott
RyanGlScott approved these changes Sep 24, 2024
View reviewed changes
x86_symbolic/tests/Main.hs Outdated Show resolved Hide resolved
x86_symbolic/src/Data/Macaw/X86/Symbolic/Regs.hs Outdated Show resolved Hide resolved
@langston-barrett langston-barrett merged commit ce64ab7 into master Sep 24, 2024
4 checks passed
@langston-barrett langston-barrett deleted the lb/x86-regs branch September 24, 2024 19:49
@langston-barrett langston-barrett mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott approved these changes

Assignees

@langston-barrett langston-barrett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langston-barrett @RyanGlScott