macaw-x86: Fix call semantics when call target involves the stack pointer
#421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointer Previously, the `macaw-x86` semantics for `call` would retrieve the call target *after* pushing the next instruction's address to the stack, but if the call target involves the stack pointer, then this would mean that it would get the next instruction's address when retrieving the call target. This is not what is intended! This patch fixes the issue by always retrieving the call target *before* pushing the next instruction's address to the stack. I have added a test case to the `macaw-x86-symbolic` test suite which demonstrates that this fix works as intended. Fixes #420.
langston-barrett
approved these changes
Aug 13, 2024
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
macaw-x86semantics forcallwould retrieve the call target after pushing the next instruction's address to the stack, but if the call target involves the stack pointer, then this would mean that it would get the next instruction's address when retrieving the call target. This is not what is intended!This patch fixes the issue by always retrieving the call target before pushing the next instruction's address to the stack. I have added a test case to the
macaw-x86-symbolictest suite which demonstrates that this fix works as intended.Fixes #420.