support alignment ops when processing statements in RegisterUse
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ptival
force-pushed
the
vr/register-use-bvand
branch
from
dc21c4c to
0986922
Compare
RyanGlScott
approved these changes
Jul 24, 2024
For some reason we were very conservative in our support or abstract operations over the processor state in the `RegisterUse` analysis. In particular, we were failing to process code such as: r23 := (bv_and r21 (0xfffffffffffffff0 :: [64])) whose goal is to align the value in r21 at a 16-byte boundary. This resulted in us failing to analyze some code that was realigning its stack pointer. With this change, the same code succeeds at propagating the abstract stack pointer offset forward.
Ptival
force-pushed
the
vr/register-use-bvand
branch
from
0986922 to
dc1591d
Compare
|
@RyanGlScott I have addressed your comments, and also added two comments that I fell will help me if I ever need to look at this code again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason we were very conservative in our support or abstract
operations over the processor state in the
RegisterUseanalysis.In particular, we were failing to process code such as:
r23 := (bv_and r21 (0xfffffffffffffff0 :: [64]))
whose goal is to align the value in r21 at a 16-byte boundary.
This resulted in us failing to analyze some code that was realigning its
stack pointer. With this change, the same code succeeds at propagating
the abstract stack pointer offset forward.