macaw-ppc: Don't assume absolute IP addresses when decoding
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`macaw-ppc` was previously assuming that addresses are absolute, which is not true for position independent executables. Extracting the offset from the address is sufficient for our purposes here (note that taking the offset from the `MemSegmentOffset` would not be right, as that offset is relative to the segment start). This is the exact same issue that was noticed in 37d8029 (in `macaw-aarch32`), but that commit forgot to fix things on the `macaw-ppc` end.
… types Now that `macaw-aarch32` and `macaw-ppc` properly handle position-independent code, the `InstructionAtUnmappedAddr` error (which could only be thrown if an IP address was found in position-independent code) is never thrown. Let's delete it.
RyanGlScott
added a commit
to RyanGlScott/pate
that referenced
this pull request
Nov 14, 2023
danmatichuk
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macaw-ppcwas previously assuming that addresses are absolute, which is not true for position independent executables. Extracting the offset from the address is sufficient for our purposes here (note that taking the offset from theMemSegmentOffsetwould not be right, as that offset is relative to the segment start).This is the exact same issue that was noticed in 37d8029 (in
macaw-aarch32), but that commit forgot to fix things on themacaw-ppcend.