crux-mir improvements for Ring verification #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't taken a close look at this since I don't feel like I'm qualified to review this in depth, but do let us know if you're blocked on a review, @spernsteiner. |
…plements the `id` function and therefore a wrong result
…ect 0 ...` is LSB but the left argument to `BVConcat` is MSB
impl 8 bv = bv
impl bvw bv = let
xsw = bvw - 8
x = BVSelect 0 8 bvw bv
xs = BVSelect 8 xsw bvw bv
in BVConcat 8 xsw x (impl xsw xs)
[crux-mir] Implement bswap intrinsic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes a few crux-mir improvements used in the Ring SHA256 verification:
MethodSpecs.Symbolictrait for larger array sizes and forWrapping<T>mem::transmuteto support splitting and merging integers (for example, convertingu32to/from[u8; 4])mir-jsonsubmodule with allow changing crux-mir binary path using CRUX_MIR env var mir-json#21, which makes it easier to runcrux-mir-comp(needed for the Ring proof)