major: various fixes, codebase improvements/cleanup, packages/sdk update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it easier to identify which user has private empowered permissions when looking at the files.
- Updated embed - Renamed lambda parameters for clarity
- Updated `HandleUpdateMessagePagesAsync` embed - Added embed timestamp restoring - Renamed lambda parameters for clarity
- Updated `GetEmbedForLog` returned embeds. - Renamed `victim` to `target`. - Formatting and identation changes for code readability. - Converted `GetColorBasedOnAction` switch statement to a switch expression for code readability.
- Updated `ShowAllStatsAsync` returned embed - Updated `AddModerationModuleToGuildAsync` returned embed - Renamed lambda parameters for clarity
- Updated embeds builders to use `withTitle()` - Minor changes to indentation for code readability
- Updated `/overview` returned response embed. - Updated `/reloadrules` command returned response embed. - Updated `/reset` command returned response embed. - Renamed lambda parameters for clarity.
- Updated `/status` command output embed. - Updated `/compare` command output embed. - Various lambda parameters renamed for clarity. - Code formatting and indentation changes for readability.
- Updated various strings. - Code formatting and indentation changes for readability.
- Updated all moderation commands output embeds. - Updated many commands description. - Renamed various lambda parameters for clarity. - Code formatting and indentation changes for readability. - More miscellaneous changes.
svr333
reviewed
Sep 4, 2024
src/AdvancedBot.Core/Commands/Preconditions/RequirePrivateList.cs
Outdated
Show resolved
Hide resolved
src/AdvancedBot.Core/Commands/Preconditions/RequireStagingList.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: svr333 <[email protected]>
Discarding the result of compensation tasks to suppress non-awaited warnings, assuming these tasks aren't awaited on purpose
- refactor `FormatNumber` to use switch expression instead of regular if else. - fixed typo in number formatting, there was 2 checks for 10k<, leading to the last one never being reached - Various visual improvements to the returned embed
Previously, using a command that was returning a paginated response would also return an error "Object reference not set to an instance of an object.". This commit fixes that issue, which allows pagination to be used on DM interactions. Also added thumbnail restoration, and cleaned up the syntax a little bit.
bryanpth
changed the title
Forgot to push that formatted file earlier
svr333
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
.NET SDKfrom7.0to8.0C# languagefrom9.0to12.0Fixes
/comparenot properly returning when the same player was asked to be compared.Improvements
readonlymodifiers on various files.Documentation
README.mdfor a clearer output.Codebase cleanup
.editorconfigto ensure proper code quality..gitattributesto ensure normalized line endings to lf internally.Continuous integration
console.ymlanddashboard.ymlworkflows.ci.yaml, which ensure proper code formatting and warning/error free application compiling.--