Updated bright star treatment and addition of saturation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmandelb
requested changes
Sep 26, 2024
FedericoBerlfein
changed the title
rmandelb
approved these changes
Sep 27, 2024
|
@aguinot Let me know if saturation implementation is ok. |
rmandelb
reviewed
Sep 27, 2024
euclidlike_imsim/ccd.py
Outdated
|
|
||
| # Apply saturation | ||
| saturation_ADU = saturation/gain | ||
| image[image > saturation_ADU] = saturation_ADU |
There was a problem hiding this comment.
image is Galsim.Image - need to make a copy of the image data and modify it and put it back
There was a problem hiding this comment.
Corrected.
|
Final changes made, updated saturation limit value to 200,000 electrons per https://www.euclid-ec.org/public/mission/vis/#:~:text=VIS%20pixels%20are%20saturated%20at,IE(AB)%3D16.0. |
rmandelb
approved these changes
Sep 27, 2024
Co-authored-by: Rachel Mandelbaum <[email protected]>
aguinot
reviewed
Sep 27, 2024
Co-authored-by: Axel Guinot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to flux value where we switch from using Euclidlike PSF to bright star PSF.
Also need to add saturation limit to
addNoisefunction inccd.py.