Extract common sed function

[DarumaDocker]

No description provided.

[juntao]

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.

---

config.json

Potential issues

1. The file is in JSON format, which is used for data interchange and cannot be considered a programming source code file. It's rather static configuration information.
2. There seems to be no bugs or syntax errors since this appears as a valid JSON object with string properties.
3. If you are looking for a function related task, it would be helpful if the patch/task is made clear because there doesn’t seem to be an extract common sed function-related change in the file provided here.

Summary of changes

:

1. Replaced "$subdomain" with static value "0x" in server_health_url and server_info_url to extract common sed function.
2. Updated URLs to maintain consistent structure across other similar configurations, likely reducing potential bugs and issues due to inconsistencies.
3. Ensured the code remains consistent with other uses of sed and improve readability by extracting a reusable function.

gaianet

Potential issues

" Start LlamaEdge API Server command failed. Exit 1"
fi
else
error " Start LlamaEdge API Server with nohup failed. Exit 1\n"
exit 1
fi
done
fi
}

Summary of changes

:

1. The sed_in_place function was added to replace platform-specific issues related with sed command variations between Linux, MacOS and Windows environments. This reduces repeated code in the script for different OS types.
2. Updates to config.json now use the sed_in_place function for consistency and better readability. It makes updating the file values platform agnostic.
3. The find $gaianet_base_dir/gaia-frp -type f -not -name 'frpc' -not -name 'frpc.toml' -exec rm -f {} ; command is used to remove all files in the directory except for frpc and frpc.toml, making it more efficient by avoiding unnecessary file operations.

install.sh

Potential issues

:
Here are the issues found in your script. Please note that this process could vary depending on your specific environment and the version of the software you're trying to install, so these may not be applicable to your case but will help identify potential problems with the installation:

1. It uses openssl without checking if it is installed which can cause issues in some environments.

2. The sed command used for modifying the frpc.toml might not work on all systems since different versions of sed handle options differently, and some may not support the option used.

3. There's a possibility that check_curl or sed_in_place are not defined functions when they are being called in your script.

4. The script lacks comments explaining its purpose or any potential issues with it.

5. The path to certain files like frpc.toml is hard-coded instead of being dynamically determined based on the location where the script is run. This may cause difficulties if the script is copied and moved around, as the paths could be incorrect then.

6. uname command could fail if it's not available in the environment.

7. The way target is set with uname -m might not work correctly on some systems (like Windows machines running WSL or systems using ARM processors).

Summary of changes

:

1. Extracted a common function for handling sed command across different operating systems to improve code reusability and reduce duplication. The new function, sed_in_place, takes care of the differences in sed -i syntax between Unix-based systems (e.g., Linux, MacOS) and Windows Subsystem for Linux(WSL).
2. Updated config.json by adding two more fields: "chat_batch_size" and "embedding_batch_size" at the 2nd line in the file using sed command. The new values are "16" and "512", respectively.
3. Modified Qdrant's telemetry setting from false to true by replacing a specific string within the configuration YAML file using sed.

[apepkuss]

LGTM