-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-3714: Added a script that generates client credentials #769
Conversation
CI job failed: https://ci.gpii.net/job/universal-tests/1681/ |
CI job passed: https://ci.gpii.net/job/universal-tests/1682/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
scripts/generateCredentials.js
Outdated
var credentialsName = process.env.GPII_CREDENTIALS_NAME; | ||
var credentialsSite = process.env.GPII_CREDENTIALS_SITE; | ||
|
||
if (!credentialsSite || !credentialsSite) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should one of these be credentialsName
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well spotted, thanks!
2. couchDBData.json: The JSON-format documents that go into the production | ||
database and ready to be inserted using an HTTP POST request like this: | ||
|
||
* curl -d @couchDBData.json -H "Content-type: application/json" -X POST http://localhost:25984/gpii/_bulk_docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the plan is to run something similar to this workflow in production (and stg)?
If so, we will want a note in gpii-infra; the one you wrote for seeding preferences for users is a good example.
CI job passed: https://ci.gpii.net/job/universal-tests/1692/ |
Merged at 804d478 |
See https://issues.gpii.net/browse/GPII-3714.
The script generates two files containing:
database and ready to be inserted using an HTTP POST request