Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3714: Added a script that generates client credentials #769

Merged
merged 3 commits into from
Apr 25, 2019

Conversation

javihernandez
Copy link
Member

@javihernandez javihernandez commented Apr 1, 2019

See https://issues.gpii.net/browse/GPII-3714.

The script generates two files containing:

  1. secret.txt: The file to be provided when building the "Secret Blower" installer. See GPII-3714: First implementation of the "secret blower" morphic-credentials-installer#1
  2. couchDBData.json: The JSON-format documents that go into the production
    database and ready to be inserted using an HTTP POST request

@gpii-bot
Copy link

gpii-bot commented Apr 1, 2019

CI job failed: https://ci.gpii.net/job/universal-tests/1681/

@gpii-bot
Copy link

gpii-bot commented Apr 1, 2019

CI job passed: https://ci.gpii.net/job/universal-tests/1682/

Copy link
Contributor

@mrtyler mrtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

var credentialsName = process.env.GPII_CREDENTIALS_NAME;
var credentialsSite = process.env.GPII_CREDENTIALS_SITE;

if (!credentialsSite || !credentialsSite) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should one of these be credentialsName?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well spotted, thanks!

2. couchDBData.json: The JSON-format documents that go into the production
database and ready to be inserted using an HTTP POST request like this:

* curl -d @couchDBData.json -H "Content-type: application/json" -X POST http://localhost:25984/gpii/_bulk_docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the plan is to run something similar to this workflow in production (and stg)?

If so, we will want a note in gpii-infra; the one you wrote for seeding preferences for users is a good example.

@gpii-bot
Copy link

gpii-bot commented Apr 5, 2019

CI job passed: https://ci.gpii.net/job/universal-tests/1692/

@cindyli
Copy link
Contributor

cindyli commented Apr 25, 2019

Merged at 804d478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants