Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy feature from evidence track #473

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Copy feature from evidence track #473

wants to merge 6 commits into from

Conversation

shashankbrgowda
Copy link
Contributor

@shashankbrgowda shashankbrgowda commented Oct 30, 2024 •
edited
Loading

Fixes #447

image
image

@shashankbrgowda shashankbrgowda self-assigned this Oct 30, 2024
@shashankbrgowda shashankbrgowda marked this pull request as ready for review November 4, 2024 11:06
garrettjstevens
garrettjstevens requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@garrettjstevens garrettjstevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this out, I wasn't able to select just the transcript, it would always select the gene, too.

checkboxes.mp4

Here's the evidence track GFF3 for the gene I was using:

SM_V10_3	WormBase_imported	gene	9658336	9659388	.	+	.	ID=gene:Smp_004310;Name=Smp_004310;biotype=protein_coding;description=V-type proton ATPase proteolipid subunit;description_source=UniProtKB/TrEMBL;description_source_acc=G4LXI9
SM_V10_3	WormBase_imported	mRNA	9658336	9659388	.	+	.	ID=transcript:Smp_004310.1;Parent=gene:Smp_004310;Name=Smp_004310.1;info=method:InterPro accession:IPR000245 description:V-ATPase proteolipid subunit %0Amethod:InterPro accession:IPR002379 description:V-ATPase proteolipid subunit C-like domain %0Amethod:InterPro accession:IPR011555 description:V-ATPase proteolipid subunit C%2C eukaryotic %0Amethod:InterPro accession:IPR035921 description:F/V-ATP synthase subunit C superfamily
SM_V10_3	WormBase_imported	exon	9658336	9658469	.	+	.	ID=exon:Smp_004310.1.1;Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	exon	9658501	9658684	.	+	.	ID=exon:Smp_004310.1.2;Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	exon	9658722	9659388	.	+	.	ID=exon:Smp_004310.1.3;Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	five_prime_UTR	9658336	9658396	.	+	.	Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	CDS	9658397	9658469	.	+	0	ID=cds:Smp_004310.1;Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	CDS	9658501	9658684	.	+	2	ID=cds:Smp_004310.1;Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	CDS	9658722	9658926	.	+	1	ID=cds:Smp_004310.1;Parent=transcript:Smp_004310.1
SM_V10_3	WormBase_imported	three_prime_UTR	9658927	9659388	.	+	.	Parent=transcript:Smp_004310.1

packages/jbrowse-plugin-apollo/src/components/CreateApolloAnnotation.tsx Outdated
const [selectedDestinationFeature, setSelectedDestinationFeature] =
useState<AnnotationFeatureSnapshot>()

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of fetching features from the server, this should look at the already-fetched features stored in session.apolloDataStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjstevens garrettjstevens garrettjstevens requested changes

Assignees

@shashankbrgowda shashankbrgowda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy feature from evidence track
2 participants
@shashankbrgowda @garrettjstevens