Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handler code behind environment variable guard #53

Closed
wants to merge 1 commit into from

Conversation

kdheepak
Copy link
Contributor

export PYHELICS_ADD_EXCEPTION_HANDLER=True for old behavior.

Fixes #47

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #53 (419e00d) into main (78e645e) will decrease coverage by 0.04%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   75.80%   75.75%   -0.05%     
==========================================
  Files          20       20              
  Lines        7064     7066       +2     
==========================================
- Hits         5355     5353       -2     
- Misses       1709     1713       +4     
Flag Coverage Δ
unit 75.75% <18.18%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
helics/capi.py 75.30% <18.18%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e645e...419e00d. Read the comment docs.

@kdheepak kdheepak closed this May 19, 2022
@kdheepak kdheepak deleted the fix-exception-handler branch May 19, 2022 19:37
@kdheepak
Copy link
Contributor Author

It turns out this is not the issue for causing segfaults when using import helics; import matplotlib. The core issue is that the helics library loads a different version of stdc++, and loading the helics library first causes further calls that expect the older version of stdc++ to fail and segfault. This could be related to the fact that the helics library may export more functions than required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Conflict with matplotlib
2 participants