Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Dutch translations. #1913

Open
1 task done
StonehengeCreations opened this issue Nov 27, 2024 · 4 comments · May be fixed by #1914
Open
1 task done

Incorrect Dutch translations. #1913

StonehengeCreations opened this issue Nov 27, 2024 · 4 comments · May be fixed by #1914
Assignees

Comments

@StonehengeCreations
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Problem description

Several strings have translated incorrectly:

  • "Turn" has been translated as "Keer om", which means "Turn around". It should be "Sla {turn_maneuver}af".
  • "Keep" has also been translated as "Keer om, resulting into people thinking they need to make a U-turn instead of continuing in the same direction on either the left or right side. It should be "Houd {turn_maneuver} aan".
  • "Onto" has been translated as "richting", which means "towards" or "in the direction of". It should be "naar".

Also, in Dutch there is difference in "rechts/links" and "rechtsaf/linksaf" (right/left) when providing navigation instructions. The "af" postfix is only used when changing directions/making a turn. This can be easily solved by putting the postfix immediately after the {turn_maneuver} - without a blank space in between.

Proposed solution

"directions": {
    "north": "noordelijke",
    "northeast": "noordoostelijke",
    "east": "oostelijke",
    "southeast": "zuidoostelijke",
    "south": "zuidelijke",
    "southwest": "zuidwestelijke",
    "west": "westelijke",
    "northwest": "noordwestelijke"
},
"arrive": {
    "default": {
        "default": "Aankomst op uw bestemming",
        "name": "Aankomst op {way_name}"
    },
    "left": {
        "default": "Uw bestemming bevindt zich aan de linkerkant",
        "name": "Aankomst op {way_name}. Uw bestemming bevindt zich aan de linkerkant"
    },
    "right": {
        "default": "Uw bestemming bevindt zich aan de rechterkant",
        "name": "Aankomst op {way_name}. Uw bestemming bevindt zich aan de rechterkant"
    },
    "straight": {
        "default": "Uw bestemming bevindt zich recht vooruit",
        "name": "Aankomst op {way_name}. Uw bestemming bevindt zich recht vooruit"
    }
},
"depart": {
    "default": {
        "default": "Vertrek in {direction} richting",
        "name": "Vertrek in {direction} richting op {way_name}"
    }
},
"roundabout": {
    "default": {
        "exit": {
            "default": "Neem op de rotonde de {exit_number} afslag",
            "name": "Neem op de rotonde de {exit_number} afslag naar {way_name}"
        },
        "default": {
            "default": "Ga de rotonde op",
            "name": "Neem op de rotonde de afslag naar {way_name}"
        }
    }
},
"turn": {
    "default": {
        "default": "Sla {turn_maneuver}af",
        "name": "Sla {turn_maneuver}af naar {way_name}"
    }
},
"continue": {
    "default": {
        "default": "Blijf {turn_maneuver} gaan",
        "name": "Blijf {turn_maneuver} gaan richting {way_name}"
    },
    "uturn": {
        "default": "Maak een U-bocht",
        "name": "Maak een U-bocht naar {way_name}"
    }
},
"keep": {
    "default": {
        "default": "Houd {turn_maneuver} aan",
        "name": "Houd {turn_maneuver} aan naar {way_name}"
    }
},
"pt": {
    "start": {
        "default": "Stap {name} in",
        "headsign": "Stap {name} in richting {headsign}"
    },
    "transfer": {
        "default": "Stap over naar {name}",
        "headsign": "Stap over naar {name} richting {headsign}"
    },
    "end": "Stap uit bij {name}"
}

Additional context

No response

Forum Topic Link

No response

@koebi koebi self-assigned this Nov 27, 2024
@koebi koebi linked a pull request Nov 27, 2024 that will close this issue
@koebi
Copy link
Collaborator

koebi commented Nov 27, 2024

Hey,

thank you so much for taking the time to check and correct the dutch translation! This is great :))

I have put your changes into a pull request - would you mind looking over that and seeing whether I missed something or messed anything up?

Best regards

@StonehengeCreations
Copy link
Author

StonehengeCreations commented Nov 27, 2024

Very glad to help out.

I am not quite sure about the "continue" translations, because it is not really clear to me on how those will be used. if you could provide me with an English example, that would be great.

@koebi
Copy link
Collaborator

koebi commented Nov 28, 2024

This is mainly used to tell people to continue driving straight, e.g. when lanes are merging/splitting.
Something like Continue straight onto A52 might come up.

@koebi
Copy link
Collaborator

koebi commented Dec 3, 2024

Do you have any further comments on this?
If not, I'd merge it as is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants