Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimators make too many assumptions about the shapes of outputs. #214

Open
josephdviviano opened this issue Nov 13, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed small Small enhancement

Comments

@josephdviviano
Copy link
Collaborator

Right now, the estimator output dim checker only looks at the final output dimension. It is implicitly assuming we are calculating something that looks like a 1-d distribution. I believe this might be too restricting for all possible Estimator use cases, but it is not currently a priority.

@josephdviviano josephdviviano added bug Something isn't working help wanted Extra attention is needed small Small enhancement labels Nov 13, 2024
@josephdviviano josephdviviano self-assigned this Nov 13, 2024
@saleml
Copy link
Collaborator

saleml commented Nov 26, 2024

Thanks for raising this.
Have you ever stumbled upon a case where an error was raised for this reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed small Small enhancement
Projects
None yet
Development

No branches or pull requests

2 participants