Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditioning example should do something #190

Open
josephdviviano opened this issue Oct 9, 2024 · 0 comments
Open

conditioning example should do something #190

josephdviviano opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request high priority Let's do these first!

Comments

@josephdviviano
Copy link
Collaborator

Right now, the conditioning example in train_conditioning.py is a red herring - the conditioning does nothing.

As suggested in a code review, we should make one of the conditions remove (at least one) of the modes in the hypergrid environment, so we can verify at test time that the conditioning is actually being used: #188 (comment)

This will require the conditioning to interact with the environment somehow which expands the scope of this a bit but should be interesting (and a high priority follow up to the original conditioning PR).

@josephdviviano josephdviviano added enhancement New feature or request high priority Let's do these first! labels Oct 9, 2024
@josephdviviano josephdviviano self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority Let's do these first!
Projects
None yet
Development

No branches or pull requests

1 participant