Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intro_gfn_continuous_line.ipynb #172

Open
saleml opened this issue Mar 21, 2024 · 1 comment
Open

Fix intro_gfn_continuous_line.ipynb #172

saleml opened this issue Mar 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@saleml
Copy link
Collaborator

saleml commented Mar 21, 2024

Running the second code cell returns TypeError: Can't instantiate abstract class Line with abstract methods backward_step, step

This is likely due to the recent changes in the environment API

@josephdviviano josephdviviano added the help wanted Extra attention is needed label Apr 2, 2024
@josephdviviano
Copy link
Collaborator

Ah, so I also thought it was due to recent changes in the environment API, but it isn't -- it was never a functional notebook and is left as a todo for me.

I've added a note at the top of the notebook to this effect.

The goal of this notebook is to demonstrate how to handle continuous policies with more complex action spaces, e.g., sampling the likelihood of exiting at each step, sampling from a mixture beta distributions (instead of the other notebook where all trajectories are the same length, and the action space is just a single gaussian). The _simple.ipynb notebook is the Gaussian version (the one we presented at the workshop).

This notebook will be completed in a future PR, so I'll leave this open.

@josephdviviano josephdviviano self-assigned this Apr 2, 2024
@josephdviviano josephdviviano added bug Something isn't working enhancement New feature or request labels Apr 2, 2024
@josephdviviano josephdviviano added this to the V2 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants